linux-ext4 - Re: [PATCH 1/3] ext2fs: Handle internal journal over 2^32 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110611162128.GK11207@thunk.org>
Date:	Sat, 11 Jun 2011 12:21:28 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...mcloud.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/3] ext2fs: Handle internal journal over 2^32 bytes

On Fri, Jun 10, 2011 at 04:00:17AM -0600, Andreas Dilger wrote:
> The write_journal_inode() code is only setting the low 32-bit i_size
> for the journal size, even though it is possible to specify a journal
> up to 10M blocks in size.  Trying to create a journal larger than 2GB
> will succeed, but an immediate e2fsck would fail.  Store i_size_high
> for the journal inode when creating it, and load it upon access.
> 
> Use s_jnl_blocks[15] to store the journal i_size_high backup.  This
> field is currently unused, as EXT2_N_BLOCKS is 15, so it is using
> s_jnl_blocks[0..14], and i_size is in s_jnl_blocks[16].
> 
> Rename the "size" argument "num_blocks" for the journal creation functions
> to clarify this parameter is in units of filesystem blocks and not bytes.
> 
> Signed-off-by: Andreas Dilger <adilger@...mcloud.com>

Added to the next branch, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html