| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110613141014.GE4907@quack.suse.cz> Date: Mon, 13 Jun 2011 16:10:14 +0200 From: Jan Kara <jack@...e.cz> To: Ted Ts'o <tytso@....edu> Cc: Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org Subject: Re: [PATCH] jbd2: Fix oops in jbd2_journal_remove_journal_head() On Sun 12-06-11 17:41:13, Ted Tso wrote: > On Wed, Jun 08, 2011 at 09:31:42PM +0200, Jan Kara wrote: > > On Mon 06-06-11 10:16:30, Ted Tso wrote: > > > On Mon, May 30, 2011 at 05:12:58PM +0200, Jan Kara wrote: > > > > /* > > > > - * For the unlocked version of this call, also make sure that any > > > > - * hanging journal_head is cleaned up if necessary. > > > > + * For the unlocked version of this call, also drop buffer_head reference. > > > > * > > > > * __jbd2_journal_refile_buffer is usually called as part of a single locked > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > > > Doesn't this paragraph refer to jbd2_journal_refile_buffer(), not > > > __jbd2_journal_refile_buffer()? Or am I missing something? > > Hmm, the comment seems to be wrong. The comment about buffer_head > > reference does not apply anymore. I'll fix that. > > Are you going to be sending me a new version of this patch with this > comment fixed? Or should I just remove it? I've replaced a comment with a better one, also fixed one more wrong comment I've found and resent the patch now. Thanks for reminding me. Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists