linux-ext4 - Re: [PATCH 1/2] ext4: Fix compilation with -DDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DFBC65F.7000208@fastmail.fm>
Date:	Fri, 17 Jun 2011 23:25:51 +0200
From:	Bernd Schubert <bernd.schubert@...tmail.fm>
To:	colyli@...il.com
CC:	linux-ext4@...r.kernel.org,
	Bernd Schubert <bernd.schubert@...m.fraunhofer.de>
Subject: Re: [PATCH 1/2] ext4: Fix compilation with -DDX_DEBUG

On 06/17/2011 08:29 PM, Coly Li wrote:
> On 2011年06月18日 00:00, Bernd Schubert Wrote:
>> From: Bernd Schubert <bernd.schubert@...m.fraunhofer.de>
>>
>> Compilation of ext4/namei.c brought up an error and warning messages
>> when compiled with -DDX_DEBUG
>>
>>
>> Signed-off-by: Bernd Schubert <bernd.schubert@...m.fraunhofer.de>
>> ---
>>  fs/ext4/namei.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>> index b754b77..6f32da4 100644
>> --- a/fs/ext4/namei.c
>> +++ b/fs/ext4/namei.c
>> @@ -288,8 +288,8 @@ static struct stats dx_show_leaf(struct dx_hash_info *hinfo, struct ext4_dir_ent
>>  				char *name = de->name;
>>  				while (len--) printk("%c", *name++);
>>  				ext4fs_dirhash(de->name, de->name_len, &h);
>> -				printk(":%x.%u ", h.hash,
>> -				       ((char *) de - base));
>> +				printk(":%x.%ld ", h.hash,
>> +				       (long) ((char *) de - base));
>>  			}
> 
> How about use %p in printk like
>> +				printk(":%x.%p ", h.hash,
>> +				       ((char *) de - base));
> 

Fine with me :) I will send updated patches on Monday.

Cheers,
Bernd
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html