linux-ext4 - Re: [PATCH] ext4:quiet 'unsed variables' compiling warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110627203442.GF2729@thunk.org>
Date:	Mon, 27 Jun 2011 16:34:42 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4:quiet 'unsed variables' compiling warnings.

On Wed, Jun 15, 2011 at 11:27:00AM +0800, Yongqiang Yang wrote:
> Delete unused variables.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 859f2ae..fece8c2 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2860,7 +2860,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac,
>  {
>  	int bsbits, max;
>  	ext4_lblk_t end;
> -	loff_t size, orig_size, start_off;
> +	loff_t size, start_off;

Unfortunately, orig_size is being used by an mb_debug statement.  So
simply removing orig_size and its initialization will cause the build
to break if CONFIG_EXT4_DEBUG is enabled.

Can you resend this patch with this part of the patch removed?

Also, for future reference I prefer for consistency's sake that the
one-line summary be:

ext4: quiet 'used variables' compiling warnings

(note the space after "ext4: ", the lack of a ending period, and the
spelling correction for "unsed"; the other change which I will
commonly make for folks, again for consistency, is to make the first
word after "ext4: " lower case --- the summary does not have to be a
complete sentence, which is why I remove the trailing period)

Thanks,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html