linux-ext4 - Re: [PATCH 3/4] ext4: clone indirect.c file from inode.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110627234156.GG2729@thunk.org>
Date:	Mon, 27 Jun 2011 19:41:56 -0400
From:	Ted Ts'o <tytso@....edu>
To:	amir73il@...rs.sourceforge.net
Cc:	linux-ext4@...r.kernel.org, Amir Goldstein <amir73il@...rs.sf.net>
Subject: Re: [PATCH 3/4] ext4: clone indirect.c file from inode.c

On Tue, Jun 21, 2011 at 12:39:27PM +0300, amir73il@...rs.sourceforge.net wrote:
> From: Amir Goldstein <amir73il@...rs.sf.net>
> 
> The next patch is going to move ext4_ind_ functions to
> indirect.c. First, we clone the file from inode.c and
> only leave code that is going to be duplicated in both files.
> This should keep the deleted lines count from inode.c in the next
> patch the same as the added lines count to indirect.c.

I really dislike cloning functions.  This becomes a maintenance
headache, since bugs that get fixed in one file might not get
propagated to another.  Since I need to manually move all of the
functions to verify nothing else changed in patches that do massive
code movement, I used the first two patches in your patch series, but
replaced the last two patches in the patch series, and replaced it
with the following:

A) Move __ext4_check_blockref() to fs/ext4/block_validity.c and
declare it extern.

B) Move ext4_truncate_failed_write() and blocks_for_truncate() to a
new function, fs/ext4/truncate.h.

C) Movement of indirect-related code to fs/ext4/indirect.c.

   	       			     	- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html