linux-ext4 - Re: [RFC] Journal credits debugging (Was: Re: Bug#615998: ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <37DE6F9F-E43F-4EB8-9A1D-6CDB59F90134@dilger.ca>
Date:	Wed, 29 Jun 2011 01:27:40 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Amir Goldstein <amir73il@...il.com>
Cc:	Jan Kara <jack@...e.cz>,
	"Moffett, Kyle D" <Kyle.D.Moffett@...ing.com>,
	"Ted Ts'o" <tytso@....edu>, Lukas Czerner <lczerner@...hat.com>,
	Sean Ryle <seanbo@...il.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	Sachin Sant <sachinp@...ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Subject: Re: [RFC] Journal credits debugging (Was: Re: Bug#615998: ...)

On 2011-06-29, at 1:10 AM, Amir Goldstein wrote:
> I would like to suggest an approach that may help us track down these
> sort of bugs more easily.
> 
> Add a new class_id argument to ext4_handle_dirty_metadata() and collect
> statistics of used credits per class_id.
> 
> There are only so many types of journaled objects:
> SUPER, GDT, BB, IB, ITB, IND, EXT, DATA, XATTR, QUOT...
> So it shouldn't be a problem to save the statistics per handle.
> 
> If you look at struct jbd2_journal_handle, you will find a bunch of h_cow_XXX
> fields intended as COW debugging counters.
> We may as well turn these fields into a generic counters array, which can
> be used by either COW debugging or credits debugging code.
> 
> This should be simple enough to implement and should provide
> a more detailed report when buffer credits have run out.
> 
> However, if we are going to modify all call sites of
> ext4_handle_dirty_metadata(), it would be wise to also add an object_id
> (or a better name) argument that will provide the group no. or inode no.
> or quota type, or any other id relevant for classification.
> 
> We can use this information, along with where, line, handle, ino,
> block_nr, buffer_credits and create a stable trace point in
> __ext4_handle_dirty_metadata().

One of the things I like about the ZFS/DMU transaction API is that instead
of the caller having to "just know" how many credits are needed to modify
the filesystem, the caller specifies the inodes/directories that will be
modified, and if new inodes are allocated in a "declaration" step before
starting the transaction.  This allows the internal code to account for the
metadata will be modified, and avoids the knowledge of journal credits for
different update types all over the code.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html