lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LFD.2.00.1106301352000.4489@dhcp-27-109.brq.redhat.com> Date: Thu, 30 Jun 2011 13:56:39 +0200 (CEST) From: Lukas Czerner <lczerner@...hat.com> To: Robin Dong <hao.bigrat@...il.com> cc: linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com> Subject: Re: [PATCH 1/2] ext4: remove redundant goto tag "repeat" On Thu, 30 Jun 2011, Robin Dong wrote: > If eh->eh_entries is smaller than eh->eh_max, the routine will > go to the "repeat" and then go to "has_space" directlly , > since argument "depth" and "eh" are not even changed. > > Therefore, goto "has_space" directly and remove redundant "repeat" tag. The patch looks good. Thanks! -Lukas > > Signed-off-by: Robin Dong <sanbai@...bao.com> > --- > fs/ext4/extents.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index eb63c7b..dc5ef91 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -1758,7 +1758,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, > goto merge; > } > > -repeat: > depth = ext_depth(inode); > eh = path[depth].p_hdr; > if (le16_to_cpu(eh->eh_entries) < le16_to_cpu(eh->eh_max)) > @@ -1780,7 +1779,7 @@ repeat: > ext_debug("next leaf isn't full(%d)\n", > le16_to_cpu(eh->eh_entries)); > path = npath; > - goto repeat; > + goto has_space; > } > ext_debug("next leaf has no free space(%d,%d)\n", > le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max)); > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists