linux-ext4 - Re: broken commit 25567a7b0fa98b390fd1ff0d4702b29c23a75bbb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110709004151.GL3331@thunk.org>
Date:	Fri, 8 Jul 2011 20:41:51 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: broken commit 25567a7b0fa98b390fd1ff0d4702b29c23a75bbb

On Fri, Jul 08, 2011 at 06:07:14PM -0600, Andreas Dilger wrote:
> In my pull from e2fsprogs git "master" branch, it contains commit
> 25567a7b0fa98b390fd1ff0d4702b29c23a75bbb "support for bigalloc
> file systems with a blocksize of 1024" that deletes the initialization
> of the flexbg_size variable from lib/ext2fs/alloc_tables.c::flexbg_offset():
> 
> -       flexbg_size = 1 << fs->super->s_log_groups_per_flex;
> -       flexbg = group / flexbg_size;
> +       size = rem_grp * elem_size;
> 
> but it continues to use flexbg_size later on in this function:

Yeah, sorry, fixed in the next branch.  I thought I had advanced the
master branch enough to fix it, but I didn't advance it enough.  Try a
pull now.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html