linux-ext4 - Re: [PATCH 2/2] ext4: avoid finding next leaf if newext->ee_block smaller than fex->ee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110711170718.GM28763@thunk.org>
Date:	Mon, 11 Jul 2011 13:07:18 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Robin Dong <hao.bigrat@...il.com>
Cc:	linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com>
Subject: Re: [PATCH 2/2] ext4: avoid finding next leaf if newext->ee_block
 smaller than fex->ee_block

On Thu, Jun 30, 2011 at 04:03:34PM +0800, Robin Dong wrote:
> If newext->ee_block is smaller than (or equal to) fex->ee_block, the call of
> ext4_ext_next_leaf_block will be useless. We need to call it only after
> newext->ee_block is greater than fex->ee_block.
> 
> Signed-off-by: Robin Dong <sanbai@...bao.com>

Added to the ext4 tree, but I cleaned up the one-line summary of the
patch:

    ext4: remove redundant goto in ext4_ext_insert_extent()

It's important that the one-line summary be much more "big picture" so
that people who are looking through the git history can understand
what the commit does.  Also, I added an explicit

From: Robin Dong <sanbai@...bao.com>

.... so that the attribution was the same as what was in your
Signed-off-by (instead of your hao.bigrat address).  If that wasn't
your intent, let me know and I'll fix it before I lock it into the
master branch.

In the future, if you are sending the patch from a different e-mail
address, it would be useful if you explicitly add a "From: " line in
the body so it's clear.  I made the assumption in this case based on
the general practice of other taobao engineers, but as I said, let me
know if you would want something else.

Thanks!!

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html