linux-ext4 - Re: [PATCH 1/3] ext4: Fix compilation with -DDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110716234106.GB2717@thunk.org>
Date:	Sat, 16 Jul 2011 19:41:06 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Bernd Schubert <bernd.schubert@...m.fraunhofer.de>
Cc:	linux-ext4@...r.kernel.org, adilger@...mcloud.com, colyli@...il.com
Subject: Re: [PATCH 1/3] ext4: Fix compilation with -DDX_DEBUG v2

On Mon, Jun 20, 2011 at 10:28:49PM +0200, Bernd Schubert wrote:
> changes from v1 -> v2:
> Use %p as suggested by Coly Li

The problem with %p:

    1)  It prints numbers that will never be larger than 4096 with as 
        "00000012"
    2)  It prints the number 0 as "  (null)".

These two things mean that we get messages like this:

names: foo:7141e93c.  (null) bar:745c4a06.00000012 baz:79817344.00000024 quux:7e85a800.00000036 ...

instead of:

names: foo:7141e93c.0 bar:745c4a06.12 baz:79817344.24 quux:7e85a800.36 ...

(did anyone even try this and check to see what would happen with %p?)

I've applied this patch, with a change so that we print the number
with %u and with an explicit cast to unsigned.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html