linux-ext4 - Re: [PATCH 04/12] ext4: rename ext4_add_groupblocks() to ext4_group_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGBYx2YJea_fimUEYAoJKM8y2D5MZURVm=wSnnc3+4_9YNknsA@mail.gmail.com>
Date:	Mon, 18 Jul 2011 18:15:11 +0800
From:	Yongqiang Yang <xiaoqiangnk@...il.com>
To:	Amir Goldstein <amir73il@...il.com>
Cc:	linux-ext4@...r.kernel.org, aedilger@...il.com
Subject: Re: [PATCH 04/12] ext4: rename ext4_add_groupblocks() to ext4_group_add_blocks()

On Mon, Jul 18, 2011 at 2:32 PM, Amir Goldstein <amir73il@...il.com> wrote:
> On Mon, Jul 18, 2011 at 5:52 AM, Yongqiang Yang <xiaoqiangnk@...il.com> wrote:
>> This patch renamed ext4_add_groupblocks() to ext4_group_add_blocks().
>
> What is the reason for the rename?
I just think ext4_group_add_blocks() is consistent with
ext4_group_extend() and ext4_group_add().

Yongqiang.
>
>>
>> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
>> ---
>>  fs/ext4/ext4.h    |    2 +-
>>  fs/ext4/mballoc.c |    4 ++--
>>  fs/ext4/resize.c  |    2 +-
>>  3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index bb0f776..bbe81db 100644
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -1799,7 +1799,7 @@ extern void ext4_free_blocks(handle_t *handle, struct inode *inode,
>>                             unsigned long count, int flags);
>>  extern int ext4_mb_add_groupinfo(struct super_block *sb,
>>                ext4_group_t i, struct ext4_group_desc *desc);
>> -extern void ext4_add_groupblocks(handle_t *handle, struct super_block *sb,
>> +extern void ext4_group_add_blocks(handle_t *handle, struct super_block *sb,
>>                                ext4_fsblk_t block, unsigned long count);
>>  extern int ext4_trim_fs(struct super_block *, struct fstrim_range *);
>>
>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>> index b97a2d2..ea80c0b 100644
>> --- a/fs/ext4/mballoc.c
>> +++ b/fs/ext4/mballoc.c
>> @@ -4656,7 +4656,7 @@ error_return:
>>  }
>>
>>  /**
>> - * ext4_add_groupblocks() -- Add given blocks to an existing group
>> + * ext4_group_add_blocks() -- Add given blocks to an existing group
>>  * @handle:                    handle to this transaction
>>  * @sb:                                super block
>>  * @block:                     start physcial block to add to the block group
>> @@ -4664,7 +4664,7 @@ error_return:
>>  *
>>  * This marks the blocks as free in the bitmap and buddy.
>>  */
>> -void ext4_add_groupblocks(handle_t *handle, struct super_block *sb,
>> +void ext4_group_add_blocks(handle_t *handle, struct super_block *sb,
>>                         ext4_fsblk_t block, unsigned long count)
>>  {
>>        struct buffer_head *bitmap_bh = NULL;
>> diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
>> index 33ab40d..374fd1c 100644
>> --- a/fs/ext4/resize.c
>> +++ b/fs/ext4/resize.c
>> @@ -1066,7 +1066,7 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es,
>>        ext4_debug("freeing blocks %llu through %llu\n", o_blocks_count,
>>                   o_blocks_count + add);
>>        /* We add the blocks to the bitmap and set the group need init bit */
>> -       ext4_add_groupblocks(handle, sb, o_blocks_count, add);
>> +       ext4_group_add_blocks(handle, sb, o_blocks_count, add);
>>        ext4_handle_dirty_super(handle, sb);
>>        ext4_debug("freed blocks %llu through %llu\n", o_blocks_count,
>>                   o_blocks_count + add);
>> --
>> 1.7.5.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>



-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html