linux-ext4 - Re: [PATCH] e2fsck: fix error in computing blocks of the ending group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E286493.6050709@redhat.com>
Date:	Thu, 21 Jul 2011 12:40:35 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
CC:	linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] e2fsck: fix error in computing blocks of the ending group

On 7/19/11 11:18 AM, Eric Sandeen wrote:
> On 07/19/2011 10:46 AM, Yongqiang Yang wrote:
>> If the blocks of a filesystem is a multiple of blocks_per_group,
>> blocks of the ending group is computed wrongly.  This patch computes
>> it by substracting blocks processed from blocks of the filesystem.
>>
>> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
>> ---
>>  e2fsck/pass5.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/e2fsck/pass5.c b/e2fsck/pass5.c
>> index f9d746c..7c4e336 100644
>> --- a/e2fsck/pass5.c
>> +++ b/e2fsck/pass5.c
>> @@ -227,7 +227,7 @@ redo_counts:
>>  				if (group == (int)fs->group_desc_count - 1)
>>  					cmp_block =
>>  						EXT2FS_NUM_B2C(fs,
>> -		ext2fs_blocks_count(fs->super) % fs->super->s_blocks_per_group);
>> +					ext2fs_blocks_count(fs->super) - i);
>>  			}
>>  
>>  			bitmap = 0;
> 
> I think it would be clearer to just get the last group block count from
> superblock information, rather than from using the loop counter.

Actually I see that I misread this... here we are dealing with
clusters per group and my proposed blocks per group helper won't help.
Sorry for the noise, I think your patch should go in as proposed.

I'll still send my helper, but I don't think it will help in this
location, and your patch is correct.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html