linux-ext4 - Re: [PATCH] ext4: Add missing cast in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110728021211.GD3133@thunk.org>
Date:	Wed, 27 Jul 2011 22:12:11 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Utako Kusaka <u-kusaka@...jp.nec.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Add missing cast in ext4_fallocate

On Mon, Jul 25, 2011 at 04:33:49PM +0900, Utako Kusaka wrote:
> Cast map.m_lblk to loff_t.
> 
> File size is corrupt when we get an ENOSPC.
> Logical block number is __u32, so new_size will be set to overflowed value.
> 
> # df -T /mnt/mp1
> Filesystem    Type   1K-blocks      Used Available Use% Mounted on
> /dev/sda6     ext4     9843276    153056   9190200   2% /mnt/mp1
> # fallocate -o 0 -l 2199023251456 /mnt/mp1/testfile
> fallocate: /mnt/mp1/testfile: fallocate failed: No space left on device
> # stat /mnt/mp1/testfile
>   File: `/mnt/mp1/testfile'
>   Size: 4293656576	Blocks: 19380440   IO Block: 4096   regular file
> Device: 806h/2054d	Inode: 12          Links: 1
> Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
> Access: 2011-07-25 13:01:31.414490496 +0900
> Modify: 2011-07-25 13:01:31.414490496 +0900
> Change: 2011-07-25 13:01:31.454490495 +0900
> 
> Signed-off-by: Utako Kusaka <u-kusaka@...jp.nec.com>

Thanks, added to the ext4 tree.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html