linux-ext4 - Re: [PATCH 1/2] ext4: get free blocks count of BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <0B54C612-6561-4EFD-894B-59CC27ABE2BA@gmail.com>
Date:	Mon, 1 Aug 2011 21:15:11 -0600
From:	Andreas Dilger <aedilger@...il.com>
To:	Ted Ts'o <tytso@....edu>
Cc:	Yongqiang Yang <xiaoqiangnk@...il.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/2] ext4: get free blocks count of BLOCK_UNINIT groups from group desc directly

On 2011-08-01, at 5:20 AM, Ted Ts'o <tytso@....edu> wrote:
> On Wed, Jul 20, 2011 at 09:32:53PM +0800, Yongqiang Yang wrote:
>> This patch teaches ext4 to get free blocks count of BLOCK_UNINIT groups from
>> group desc directly.
>> 
>> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
> 
> The reason why we weren't doing this is because older versions of
> e2fsprogs I don't think set the free blocks count correctly.  Or at
> least, I have a vague memory that this was the case.  I'll have to do
> some code archeology before can be 100% sure this is safe to do.

I think the other reason is that this gives the kernel code some flexibility in how the group is formatted (e.g. flex_bg or whatever may move allocated blocks around).

Cheers, Andreas--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html