linux-ext4 - Re: [PATCH 2/4] fs/ext2/balloc.c: delete useless initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110804103954.GG17196@quack.suse.cz>
Date:	Thu, 4 Aug 2011 12:39:54 +0200
From:	Jan Kara <jack@...e.cz>
To:	Julia Lawall <julia@...u.dk>
Cc:	Jan Kara <jack@...e.cz>, kernel-janitors@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] fs/ext2/balloc.c: delete useless initialization

On Thu 04-08-11 12:29:32, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> Delete nontrivial initialization that is immediately overwritten by the
> result of an allocation function.
  Thanks. Merged.

								Honza
> 
> The semantic match that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> type T;
> identifier i;
> expression e;
> @@
> 
> (
> T i = \(0\|NULL\|ERR_PTR(...)\);
> |
> -T i = e;
> +T i;
> )
> ... when != i
> i = \(kzalloc\|kcalloc\|kmalloc\)(...);
> 
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  fs/ext2/balloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -u -p a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -421,7 +421,7 @@ static inline int rsv_is_empty(struct ex
>  void ext2_init_block_alloc_info(struct inode *inode)
>  {
>  	struct ext2_inode_info *ei = EXT2_I(inode);
> -	struct ext2_block_alloc_info *block_i = ei->i_block_alloc_info;
> +	struct ext2_block_alloc_info *block_i;
>  	struct super_block *sb = inode->i_sb;
>  
>  	block_i = kmalloc(sizeof(*block_i), GFP_NOFS);
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html