linux-ext4 - Re: [PATCH 1/2 bigalloc] e2fsprogs: change "blocks" to "clusters" in dumpe2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <59AFE301-7CEF-47EF-8B0E-3B8F819C93BF@dilger.ca>
Date:	Fri, 5 Aug 2011 00:35:31 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Robin Dong <hao.bigrat@...il.com>
Cc:	linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com>
Subject: Re: [PATCH 1/2 bigalloc] e2fsprogs: change "blocks" to "clusters" in dumpe2fs

On 2011-08-04, at 10:27 PM, Robin Dong wrote:
> From: Robin Dong <sanbai@...bao.com>
> 
> When using dumpe2fs to display group detail of a bigalloc-fs, it displays like:
> 
> Group 413: (Blocks 54132737-54263808)
> Block bitmap at 54132737 (+0), Inode bitmap at 54132738 (+1)
> Inode table at 54132739-54133761 (+2)
> 8127 free blocks, 8184 free inodes, 0 directories
> Free blocks: 54133776-54263792
> Free inodes: 3379993-3388176
> 
> The "8127 free blocks" should be "8127 free clusters".

Perhaps it is good to show both the free clusters and the equivalent free blocks, or maybe even free kB, since having units of e.g. 64kB clusters is hard to understand.

> This patch is based on "next" branch of e2fsprogs.
> 
> Signed-off-by: Robin Dong <sanbai@...bao.com>
> ---
> misc/dumpe2fs.c |   21 +++++++++++++++------
> 1 files changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> index 9a0dd46..bb4eef1 100644
> --- a/misc/dumpe2fs.c
> +++ b/misc/dumpe2fs.c
> @@ -226,12 +226,21 @@ static void list_desc (ext2_filsys fs)
> 			    inode_blocks_per_group - 1);
> 		print_bg_rel_offset(fs, ext2fs_inode_table_loc(fs, i), 1,
> 				    first_block, last_block);
> -		printf (_("\n  %u free blocks, %u free inodes, "
> -			  "%u directories%s"),
> -			ext2fs_bg_free_blocks_count(fs, i),
> -			ext2fs_bg_free_inodes_count(fs, i),
> -			ext2fs_bg_used_dirs_count(fs, i),
> -			ext2fs_bg_itable_unused(fs, i) ? "" : "\n");
> +		if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
> +					EXT4_FEATURE_RO_COMPAT_BIGALLOC))
> +			printf (_("\n  %u free clusters, %u free inodes, "
> +				  "%u directories%s"),
> +				ext2fs_bg_free_blocks_count(fs, i),
> +				ext2fs_bg_free_inodes_count(fs, i),
> +				ext2fs_bg_used_dirs_count(fs, i),
> +				ext2fs_bg_itable_unused(fs, i) ? "" : "\n");
> +		else
> +			printf (_("\n  %u free blocks, %u free inodes, "
> +				  "%u directories%s"),
> +				ext2fs_bg_free_blocks_count(fs, i),
> +				ext2fs_bg_free_inodes_count(fs, i),
> +				ext2fs_bg_used_dirs_count(fs, i),
> +				ext2fs_bg_itable_unused(fs, i) ? "" : "\n");
> 		if (ext2fs_bg_itable_unused(fs, i))
> 			printf (_(", %u unused inodes\n"),
> 				ext2fs_bg_itable_unused(fs, i));
> -- 
> 1.7.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html