lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.1108052104320.4636@ask.diku.dk>
Date:	Fri, 5 Aug 2011 21:08:13 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization

On Fri, 5 Aug 2011, Eric Sandeen wrote:

> On 8/4/11 5:40 AM, Jan Kara wrote:
> > On Thu 04-08-11 12:29:31, Julia Lawall wrote:
> >> From: Julia Lawall <julia@...u.dk>
> >>
> >> Delete nontrivial initialization that is immediately overwritten by the
> >> result of an allocation function.
> >   Thanks. Merged.
> 
> Just FWIW, I was curious how this ended up here.
> 
> It looks like this has been there since 2005, and both
> lines went in in the same commit (i.e. it didn't creep in over time).
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=a66d457d8878fe8d09bc81f0d5e6ac40caec6eb7

Actually, the old code had the same property, for the rsv variable...

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ