lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Aug 2011 22:49:33 -0400 From: Ted Ts'o <tytso@....edu> To: Robin Dong <hao.bigrat@...il.com> Cc: linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com> Subject: Re: [PATCH 1/2 bigalloc] e2fsprogs: remove wrong EXT2FS_C2B in check_block_end On Thu, Aug 04, 2011 at 11:48:02AM +0800, Robin Dong wrote: > From: Robin Dong <sanbai@...bao.com> > > The argument "save_blocks_count" and the block bitmap has the unit of cluster, > so it don't need EXT2FS_C2B to convert argument "i". > > This patch is based on "next" branch of e2fsprogs. > > Signed-off-by: Robin Dong <sanbai@...bao.com> > Cc: Ted Ts'o <tytso@....edu> No, I don't think this is right. Regardless of whether the unit of the block bitmap is cluster- or block- (only while mke2fs is running, and only initially) based, the argument to ext2fs_{test,mark,unmark}_block_bitmap is always in blocks. That's why the EXT2FS_C2B is necessary. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists