linux-ext4 - Re: [PATCH] ext4: remove deprecated oldalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110815152729.GE6597@quack.suse.cz>
Date:	Mon, 15 Aug 2011 17:27:29 +0200
From:	Jan Kara <jack@...e.cz>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org,
	tytso@....edu, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext4: remove deprecated oldalloc

On Mon 15-08-11 16:21:27, Lukas Czerner wrote:
> On Thu, 11 Aug 2011, Andreas Dilger wrote:
> > On 2011-08-11, at 8:58 AM, Lukas Czerner wrote:
> > > On Tue, 7 Jun 2011, Lukas Czerner wrote:
> > >> For a long time now orlov is the default block allocator in the ext4. It
> > >> performs better than the old one and no one seems to claim otherwise so
> > >> we can safely drop it and make oldalloc and orlov mount option
> > >> deprecated.
> > >> 
> > >> This is a part of the effort to reduce number of ext4 options hence the
> > >> test matrix.
> > >> 
> > >> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> > > 
> > > ping
> > 
> > I'm OK with removing this, I don't think anyone uses it, and it has almost
> > no meaning with flex_bg anyway.
> > 
> > That said, "orlov" is also mostly meaningless with flex_bg as well, since
> > there is very little real benefit/affinity from inodes being "close" to
> > their data blocks.  We gain far more benefit from keeping the inodes
> > together than spreading them out and keeping them close to the data blocks.
> 
> What about removing it for ext3 as well ? I can prepare a patch.
  OK, let's start warning the option is deprecated and will be removed from
ext3. We can remove it after 2-3 releases...

> Also note that there is a bug in the OLDALLOC where if there is
> approximately the same number of inodes in all of the allocation groups
> it might result in the state where no group has less free inode count
> than the average, hence we get ENOSPC even though there is enough space
> for the inode to be allocated. It is unlikely, but it is there.
  Fix for this would be nice.

> So Ted, could you take the patch ?
  ext3 patches go through my tree.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html