lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 25 Aug 2011 10:28:13 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Robin Dong <hao.bigrat@...il.com>
Cc:	linux-ext4@...r.kernel.org, Ronbin Dong <sanbai@...bao.com>
Subject: Re: [PATCH 1/2] ext4: remove redundant argument in mb_find_extent()

On 2011-08-25, at 5:36 AM, Robin Dong wrote:
> From: Ronbin Dong <sanbai@...bao.com>
> 
> The argument of "ord" in mb_find_extent is not necessary anymore.
> 
> Signed-off-by: Robin Dong <sanbai@...bao.com>
> ---
> fs/ext4/mballoc.c |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)

This patch doesn't remove the declaration "int ord;" at the start of the function.

> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 17a5a57..0702627 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1432,9 +1432,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
> 		if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
> 			break;
> 
> -		ord = mb_find_order_for_block(e4b, next);
> +		order = mb_find_order_for_block(e4b, next);
> 
> -		order = ord;
> 		block = next >> order;
> 		ex->fe_len += 1 << order;
> 	}
> -- 
> 1.7.4.1

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists