linux-ext4 - e2fsck sigcatcher breaks valgrind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <A1043F1C-DAAD-4FAB-B8F4-82AB00E21DEF@whamcloud.com>
Date:	Fri, 2 Sep 2011 11:38:09 -0600
From:	Andreas Dilger <adilger@...mcloud.com>
To:	Theodore Tso <tytso@....edu>, Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4 List <linux-ext4@...r.kernel.org>
Subject: e2fsck sigcatcher breaks valgrind

I was reading Eric's recent commit message in "next" about how he used
e2fsprogs "./test_script --valgrind" to find the uninitialized memory and
thought I would try it myself.  To my dismay it was failing on my system with:

==2806==    at 0x3566A0F5BE: __libc_sigaction (in /lib64/libpthread-2.12.2.so)
==2806==    by 0x4321A3: sigcatcher_setup (sigcatcher.c:224)
==2806==    by 0x40F4DE: main (unix.c:1027)
==2806==  Address 0x7fefffe18 is on thread 1's stack
==2806==
==2806== Syscall param rt_sigaction(act->sa_mask) points to uninitialised byte(s)

After a bunch of testing as to why this system was not working correctly,
it turns out that the problem is in the later commit 9b3018a82e843d.
Reverting that commit fixes the problem and allows --valgrind tests to pass.

I also noticed (for Lukas), "./test_script --valgrind i_e2image" fails with:

i_e2image: Create/convert raw and qcow2 disk images: ./i_e2image/script: line 2: test: too many arguments

That is due to:

   if test -x $E2IMAGE; then

expanding to:

   if test -x valgrind -q --sim-hints=lax-ioctls ../misc/e2image; then

It probably needs some parameter manipulation to check only the last parameter.

Cheers, Andreas
--
Andreas Dilger 
Principal Engineer
Whamcloud, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html