linux-ext4 - Re: [PATCH 13/37] dumpe2fs: Display inode bitmap checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110905192051.GV12086@tux1.beaverton.ibm.com>
Date:	Mon, 5 Sep 2011 12:20:51 -0700
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	Theodore Tso <tytso@....edu>,
	Sunil Mushran <sunil.mushran@...cle.com>,
	Amir Goldstein <amir73il@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Mingming Cao <cmm@...ibm.com>,
	Joel Becker <jlbec@...lplan.org>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	Coly Li <colyli@...il.com>
Subject: Re: [PATCH 13/37] dumpe2fs: Display inode bitmap checksum

On Sun, Sep 04, 2011 at 12:30:32PM -0600, Andreas Dilger wrote:
> On 2011-08-31, at 6:36 PM, "Darrick J. Wong" <djwong@...ibm.com> wrote:
> > Display the inode bitmap checksum for each block group.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@...ibm.com>
> > ---
> > misc/dumpe2fs.c |    5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > 
> > diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> > index 7d74e84..ed207cb 100644
> > --- a/misc/dumpe2fs.c
> > +++ b/misc/dumpe2fs.c
> > @@ -220,6 +220,11 @@ static void list_desc (ext2_filsys fs)
> >        print_number(ext2fs_inode_bitmap_loc(fs, i));
> >        print_bg_rel_offset(fs, ext2fs_inode_bitmap_loc(fs, i), 0,
> >                    first_block, last_block);
> > +        if (fs->super->s_desc_size >= EXT2_MIN_DESC_SIZE_64BIT &&
> > +            fs->super->s_feature_ro_compat &
> > +            EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)
> > +            printf(_(", checksum 0x%08x"),
> 
> Since this line is already very long, printing "csum" should be enough. 

Ok.

--D
> 
> > +                  ext2fs_inode_bitmap_checksum(fs, i));
> >        fputs(_("\n  Inode table at "), stdout);
> >        print_range(ext2fs_inode_table_loc(fs, i),
> >                ext2fs_inode_table_loc(fs, i) +
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html