linux-ext4 - Re: [PATCH 0/6 v7] ext4: fix 1k block bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E664C83.2080001@linux.vnet.ibm.com>
Date:	Tue, 06 Sep 2011 09:38:27 -0700
From:	Allison Henderson <achender@...ux.vnet.ibm.com>
To:	"Ted Ts'o" <tytso@....edu>
CC:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 0/6 v7] ext4: fix 1k block bugs

On 09/05/2011 09:59 PM, Ted Ts'o wrote:
> Allison,
>
> Many, many thanks for your work on this patch series!!  It's clearly
> been a very long slog.
>
> I've pulled in the first three patches, since I think those are
> clearly correct at this point.  One minor change I've made was I fixed
> the spelling the flag, which I channged to
> EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED.  (Sorry, but seeing MAPED
> everywhere was just grating on my nerves.  :-)
>
> I didn't want to apply your 4th patch in the series since we're
> planning on reducing the usage of i_mutex in the fs/ext4 code proper,
> as recommended by Christoph.  It wasn't immediately obvious to me
> whether it was safe to apply any of the patches after #4, so for now
> I've just merged in the first three, since they clearly fix real
> problems that show up in xfstests.
>
> Can you comment on whether patches #5, #6, and #7 depend on #4?
>
> Thanks,
>
> 						- Ted

Hi Ted,

Patches 5 and 6 do not depend on 4, and this set only has 6 patches, so 
no need to worry about patch 7 :)  So it is ok to just skip patch 4, I 
will see if I can find another way to solve the race conditions 
Yongqiang pointed out with out the use of i_mutex.  Many thanks to you 
too for all the help along the way. :)

Allison Henderson

> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html