linux-ext4 - Re: [PATCH] mke2fs: Use ext2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Sep 2011 22:58:43 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] mke2fs: Use ext2fs_flush() only once

Thanks, applied, with an obvious bugfix:

> -void print_check_message(ext2_filsys fs)
> +void print_check_message(unsigned int mnt, unsigned int check)
>  {
>  	printf(_("This filesystem will be automatically "
>  		 "checked every %d mounts or\n"
>  		 "%g days, whichever comes first.  "
>  		 "Use tune2fs -c or -i to override.\n"),
> -	       fs->super->s_max_mnt_count,
> -	       (double)fs->super->s_checkinterval / (3600 * 24));
> +		mnt, check / (3600 * 24));
>  }

../../misc/util.c: In function ‘print_check_message’:
../../misc/util.c:291: warning: format ‘%g’ expects type ‘double’, but argument 3 has type ‘unsigned int’

the (double) cast was dropped in your patch.

The message should be made a bit better in the case that
s_max_mnt_count or s_checkinterval is zero, but that's a separate
patch.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html