linux-ext4 - Re: [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110915122800.GA4739@quack.suse.cz>
Date:	Thu, 15 Sep 2011 14:28:00 +0200
From:	Jan Kara <jack@...e.cz>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	linux-ext4@...r.kernel.org, jack@...e.cz, tytso@....edu
Subject: Re: [PATCH] ext4: let ext4_page_mkwrite stop started handle in
 failure

On Thu 15-09-11 10:56:30, Yongqiang Yang wrote:
> The started journal handle should be stopped in failure case.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
  Correct.
  Acked-by: Jan Kara <jack@...e.cz>

									Honza
> ---
>  fs/ext4/inode.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index bcf5257..c8529be 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -4624,6 +4624,7 @@ retry_alloc:
>  			  PAGE_CACHE_SIZE, NULL, do_journal_get_write_access)) {
>  			unlock_page(page);
>  			ret = VM_FAULT_SIGBUS;
> +			ext4_journal_stop(handle);
>  			goto out;
>  		}
>  		ext4_set_inode_state(inode, EXT4_STATE_JDATA);
> -- 
> 1.7.5.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html