linux-ext4 - Re: [PATCH] libext2fs: reserve exclude bitmap fields in group descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Sep 2011 10:21:37 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Amir Goldstein <amir73il@...il.com>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	"Darrick J. Wong" <djwong@...ibm.com>,
	Sunil Mushran <sunil.mushran@...cle.com>,
	Andi Kleen <andi@...stfloor.org>,
	Mingming Cao <cmm@...ibm.com>,
	Joel Becker <jlbec@...lplan.org>, linux-ext4@...r.kernel.org,
	Coly Li <colyli@...il.com>,
	Yongqiang Yang <xiaoqiangnk@...il.com>
Subject: Re: [PATCH] libext2fs: reserve exclude bitmap fields in group
 descriptor

On Thu, Sep 15, 2011 at 05:03:37PM +0300, Amir Goldstein wrote:
> > I'd prefer if these comments were "Snapshot exclude bitmap block" so
> > that it is more clear what an exclude bitmap is used for.
> 
> I'll change that.

I'll be sending out a combined patch very shortly which adds the
necessary fields for the snapshot and metadata checksum fields.  I
just want to make sure we're all on the same page about reserved
fields as far as the on-disk format is concerned.

> >
> > For consistency, it would also be good to name these "_lo" to match the
> > kernel fields.
> >
> 
> That's a major cleanup.
> Forgive me for not picking up that glove...

One way of handling these sorts of cleanups is to make the change in
the header file, and then do something like this:

#define bg_exclude_bitmap   bg_exclude_bitmap_lo

Then once you add the accessor functions to set/get the
exclude_bitmap, you can delete the #define to make sure you fixed up
all of your code to actually use the accessor functions.

       	    	    	     	     	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html