[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110915175755.GK15782@thunk.org>
Date: Thu, 15 Sep 2011 13:57:55 -0400
From: Ted Ts'o <tytso@....edu>
To: Amir Goldstein <amir73il@...il.com>
Cc: "Darrick J. Wong" <djwong@...ibm.com>, linux-ext4@...r.kernel.org
Subject: Re: On-disk field assignments for metadata checksum and snapshots
On Thu, Sep 15, 2011 at 07:01:47PM +0300, Amir Goldstein wrote:
> > + { E2P_FEATURE_COMPAT, EXT2_FEATURE_COMPAT_EXCLUDE_BITMAP,
> > + "snapshot" },
>
> The feature name should read "exclude_bitmap".
> This is a COMPAT feature which should be set by default on every mkfs.ext4.
> The "has_snapshot" (or "snapshots") feature is a RO_COMPAT feature, which
> can be turned on and off, depending on whether you want to enable or
> disable snapshots.
Yeah, I was trying to use a name which would be a bit more descriptive
than "exclude_bitmap", but I agree that will get very confusing with
the "has_snapshot" feature name.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists