linux-ext4 - Re: [PATCH 1/1 v2 RESEND] mke2fs: check that auto-detected blocksize <= sys_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110916031148.GP28181@thunk.org>
Date:	Thu, 15 Sep 2011 23:11:48 -0400
From:	Ted Ts'o <tytso@....edu>
To:	"Yury V. Zaytsev" <yury@...rup.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/1 v2 RESEND] mke2fs: check that auto-detected
 blocksize <= sys_page_size

On Wed, Aug 10, 2011 at 10:48:43AM +0200, Yury V. Zaytsev wrote:
> Block size can be specified manually via the -b option or deduced
> automatically. Unfortunately, the check that it is still smaller than
> the system page size is only performed right after the command line
> options are parsed.
> 
> Therefore, if buggy or inappropriately installed/configured hardware
> hints that larger block sizes have to be used, mkfs will silently create
> a file system which can not be mounted on the system in question.
> 
> By moving the check beyond the last assignment to blocksize it is now
> ensured, that mkfs will issue a warning even if inappropriate blocksize
> was auto-detected.
> 
> The new behavior can be easily tested, by exporting the following
> variables before running mkfs:
> 
>     export MKE2FS_DEVICE_SECTSIZE=8192
>     export MKE2FS_DEVICE_PHYS_SECTSIZE=8192
> 
> Signed-off-by: Yury V. Zaytsev <yury@...rup.com>
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Thanks, I've merged this into the next branch.  Apologies for the delay.

	     	    	      	       - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html