linux-ext4 - Re: [PATCH 2/2] xfstest: fsstress add EXT2_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110918200300.GB14899@infradead.org>
Date:	Sun, 18 Sep 2011 16:03:00 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	xfs@....sgi.com, linux-fsdevel@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/2] xfstest: fsstress add EXT2_IOC_{SET,GET}FLAGS
 operations

On Sun, Sep 18, 2011 at 06:54:59PM +0400, Dmitry Monakhov wrote:
> Add two new operations:
> - getattr: ioctl(fd, EXT2_IOC_GETFLAGS, &fl)
> - setattr: ioctl(fd, EXT2_IOC_SETFLAGS, &random_flags)
> By default IOC_SET_SETFLAGS has zero probability because
> it may produce inodes with APPEND or IMMUTABLE flags which
> are not deletable by default. Let's assumes that one who
> enable it knows how to delete such inodes.
> For example like follows:
> find $TEST_PATH -exec chattr -i -a {} \;
> rm -rf $TEST_PATH

In general I like this, but:

 - please provide a testcase actually using this new feature, and
 - please don't require e2fsprogs just for the ioctl subcommands,
   and use the FS_IOC_GET/SETFLAGS names provided by recent kernels
   in fs.h instead.  You might still need an ifdef for old kernels,
   like src/t_immutable.c does.  In fact it might be a good idea
   to just provide the values for them if they aren't present in
   a header shared by fsstress and t_immutable.c

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html