linux-ext4 - Re: [PATCH 4/4] e2fsck: regression tests for INCOMPAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <324442E2-9768-41F8-AF0D-0B6C1F96AB97@whamcloud.com>
Date:	Fri, 23 Sep 2011 17:51:57 -0600
From:	Andreas Dilger <adilger@...mcloud.com>
To:	Theodore Tso <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 4/4] e2fsck: regression tests for INCOMPAT_MMP feature

On 2011-09-23, at 5:38 PM, Andreas Dilger wrote:
> Add tests for the MMP feature - creating a filesystem with mke2fs
> and MMP enabled, enable/disable MMP with tune2fs, disabling the
> e2fsck MMP flag with tune2fs after a failed e2fsck, and e2fsck
> checking and fixing a corrupt MMP block.
> 
> The MMP tests need to be run from a real disk, not tmpfs, because
> tmpfs doesn't support O_DIRECT reads, which MMP uses to ensure
> that reads from the MMP block are not filled from the page cache.
> Using a local disk does not slow down the tests noticably, since
> they wait to detect if the MMP block is being modified.
> 
> Signed-off-by: Andreas Dilger <adilger@...mcloud.com>
> 
> #
> # ERROR: trailing whitespace
> # #19: FILE: tests/f_mmp/expect.1:13:
> # +Superblock backups stored on blocks: $
> #
> # ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
> # #22: FILE: tests/f_mmp/expect.1:16:
> # +Allocating group tables: 0/2...1/2...   ...done
> #                              ^

Sigh, my bad.  I installed an automatic git prepare_commit_msg hook that
runs checkpatch.pl against the patch, but it doesn't like the format of
the expect output (which is not C code and probably should be ignored).

Please delete this stuff out of the comments, or I can resubmit if you want.

Cheers, Andreas
--
Andreas Dilger 
Principal Engineer
Whamcloud, Inc.



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html