linux-ext4 - Re: [RFC PATCH V2 2/6] ext4: add a delayed extents tree in inode info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGBYx2bYWs8cSp08w1_CFH+e32w0wH0EW-GMOXVEgqy58JEfng@mail.gmail.com>
Date:	Thu, 29 Sep 2011 15:09:25 +0800
From:	Yongqiang Yang <xiaoqiangnk@...il.com>
To:	Tao Ma <tm@....ma>
Cc:	linux-ext4@...r.kernel.org, jack@...e.cz, jeff.liu@...cle.com,
	achender@...ux.vnet.ibm.com, adityakali@...gle.com
Subject: Re: [RFC PATCH V2 2/6] ext4: add a delayed extents tree in inode info

On Thu, Sep 29, 2011 at 2:56 PM, Tao Ma <tm@....ma> wrote:
> Hi Yongqiang,
> On 09/29/2011 01:08 PM, Yongqiang Yang wrote:
>> This patch adds a delayed extents tree in inode info, so that
>> delayed extents can be look up quickly.  Without the tree
>> delayed extents are identified by looking up page cache.
>>
>> With the tree, FIEMAP, SEEK_HOLE/DATA, bigalloc and writeout
>> path can be optimized a lot.
>>
>> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
>> ---
>>  fs/ext4/ext4.h |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index ccfa81f..d3c6b97 100644
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -760,6 +760,8 @@ struct ext4_ext_cache {
>>       __u32           ec_len; /* must be 32bit to return holes */
>>  };
>>
>> +#include "delayed_extents.h"
>> +
>>  /*
>>   * fourth extended file system inode data in memory
>>   */
>> @@ -837,6 +839,9 @@ struct ext4_inode_info {
>>       struct list_head i_prealloc_list;
>>       spinlock_t i_prealloc_lock;
>>
>> +     /* delayed extents */
>> +     struct ext4_de_tree i_de_tree;
>> +
> Can we integrate this patch with patch 1/6?
> I think it would be beneficial for the reviewer to see both the
> definition of the structure and the place you put it.
Ok.  Thank you for your advice.

I will do that in next version.

Yongqiang.

>
> Thanks
> Tao
>>       /* ialloc */
>>       ext4_group_t    i_last_alloc_group;
>>
>
>



-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html