linux-ext4 - [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1317339500-4341-3-git-send-email-nikitas_angelinas@xyratex.com>
Date:	Fri, 30 Sep 2011 00:38:20 +0100
From:	Nikitas Angelinas <nikitasangelinas@...il.com>
To:	tytso@....edu, adilger.kernel@...ger.ca, adilger@...mcloud.com,
	johann@...mcloud.com
Cc:	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	nikitas_angelinas@...atex.com, andrew_perepechko@...atex.com,
	nikitasangelinas@...il.com
Subject: [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd

Current logic would print an error message only once, and then
'failed_writes' would stay at 1. Rework the loop to increment
'failed_writes' and print the error message every s_mmp_update_interval
* 60 seconds, as intended according to the comment.

Perhaps it would be better to reset 'failed_writes' to 0 on every
successful write, such that new errors are noticed sooner, but maybe in
the interest of efficiency it would be best not to add an operation on
every kmmpd thread run?

Signed-off-by: Nikitas Angelinas <nikitas_angelinas@...atex.com>
Signed-off-by: Andrew Perepechko <andrew_perepechko@...atex.com>
Acked-by: Andreas Dilger <adilger@...ger.ca>
---
 fs/ext4/mmp.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 2fca64e..6b32742 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -125,8 +125,9 @@ static int kmmpd(void *data)
 		 * Don't spew too many error messages. Print one every
 		 * (s_mmp_update_interval * 60) seconds.
 		 */
-		if (retval && (failed_writes % 60) == 0) {
-			ext4_error(sb, "Error writing to MMP block");
+		if (retval) {
+			if ((failed_writes % 60) == 0)
+				ext4_error(sb, "Error writing to MMP block");
 			failed_writes++;
 		}
 
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html