linux-ext4 - Re: [PATCH v2] ext4: don't work without procfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1110051456440.4423@dhcp-27-109.brq.redhat.com>
Date:	Wed, 5 Oct 2011 15:00:45 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	Yargil <yargil@...e.fr>
cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] ext4: don't work without procfs

On Tue, 4 Oct 2011, Yargil wrote:

> Regression from commit dd68314ccf3fb918c1fb6471817edbc60ece4b52
> The problem come from the test of the return value of proc_mkdir
> that is always false without procfs and abort the init of ext4.

Looks good. Thanks!

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> ---
>  fs/ext4/super.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 44d0c8d..9b51b17 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4985,8 +4985,10 @@ static int __init ext4_init_fs(void)
>  	if (!ext4_kset)
>  		goto out6;
>  	ext4_proc_root = proc_mkdir("fs/ext4", NULL);
> +#ifdef CONFIG_PROC_FS
>  	if (!ext4_proc_root)
>  		goto out5;
> +#endif
>  
>  	err = ext4_init_feat_adverts();
>  	if (err)
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html