linux-ext4 - Re: [PATCH] ext3: Remove the obsolete broken EXT3_IOC32_WAIT_FOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111010162700.GG3944@quack.suse.cz>
Date:	Mon, 10 Oct 2011 18:27:00 +0200
From:	Jan Kara <jack@...e.cz>
To:	Ted Ts'o <tytso@....edu>
Cc:	Jan Kara <jack@...e.cz>, Tao Ma <tm@....ma>,
	linux-ext4@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] ext3: Remove the obsolete broken
 EXT3_IOC32_WAIT_FOR_READONLY.

On Sat 08-10-11 16:52:35, Ted Tso wrote:
> On Sat, Oct 08, 2011 at 12:12:33AM +0200, Jan Kara wrote:
> > On Fri 07-10-11 23:21:18, Tao Ma wrote:
> > > From: Tao Ma <boyu.mt@...bao.com>
> > > 
> > > There are no user of EXT3_IOC32_WAIT_FOR_READONLY and also it is
> > > broken. No one set the set_ro_timer, no one wake up us and our
> > > state is set to TASK_INTERRUPTIBLE not RUNNING. So remove it.
> >   Hmm, I vaguely recall Andrew had some debugging patches which were using
> > turn_ro_timer and this functionality. But I'm not sure if they are still
> > usable or if they still make sense when one can easily test crashing using
> > virtual machines... Andrew?
> 
> That's why I decided to accept the corresponding patch for ext4; if
> the rest of debugging patch is out-of-tree, then might as well have it
> all out-of-tree --- and killall qemu is probably a better way of
> testing this anyway.
  OK. I've merged the patch in my tree. If Andrew shouts loudly, I can
always revert it :)

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html