linux-ext4 - Re: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize var(eh) before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGBYx2ZVt1=QJFDuGrC6NxXkZtP-J51s=i9eh-zRYYx7GdcBrw@mail.gmail.com>
Date:	Tue, 1 Nov 2011 11:31:36 +0800
From:	Yongqiang Yang <xiaoqiangnk@...il.com>
To:	linux-ext4@...r.kernel.org, Eric Gouriou <egouriou@...gle.com>
Cc:	Yongqiang Yang <xiaoqiangnk@...il.com>
Subject: Re: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize
 var(eh) before using it

Hi Eric,

Sorry, Cc did not work in git.

Yongqiang.
---------- Forwarded message ----------
From: Yongqiang Yang <xiaoqiangnk@...il.com>
Date: Tue, Nov 1, 2011 at 9:21 AM
Subject: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize
var(eh) before using it
To: linux-ext4@...r.kernel.org
Cc: Yongqiang Yang <xiaoqiangnk@...il.com>


ext4_ext_convert_to_initialized() does not initialize eh before using it
and this is introduced in commit 864d21652.

Cc:Eric Gouriou <egouriou@...gle.com>
Cc:"Theodore Ts'o" <tytso@....edu>
Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
---

Hi Eric,

Was that patch tested?

 fs/ext4/extents.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 9dfdf8f..2798945 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2944,6 +2944,7 @@ static int
ext4_ext_convert_to_initialized(handle_t *handle,
               eof_block = map->m_lblk + map->m_len;

       depth = ext_depth(inode);
+       eh = path[depth].p_hdr;
       ex = path[depth].p_ext;
       ee_block = le32_to_cpu(ex->ee_block);
       ee_len = ext4_ext_get_actual_len(ex);
--
1.7.5.1




-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html