linux-ext4 - Re: e2fsprogs: Avoid infinite loop in ext2fs_find_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <121461D1-4A28-4B65-960D-7549D2782FFA@mit.edu>
Date:	Thu, 3 Nov 2011 11:27:54 -0400
From:	Theodore Tso <tytso@....EDU>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Theodore Tso <tytso@....edu>, Niu <niu@...mcloud.com>,
	linux-ext4@...r.kernel.org
Subject: Re: e2fsprogs: Avoid infinite loop in ext2fs_find_block_device()


On Nov 3, 2011, at 10:47 AM, Eric Sandeen wrote:

> 
> My only concern would be that depth 5 isn't totally unreasonable in real life, and this causes it to silently stop searching, right?
> Would there be much harm in making the limit much higher, to be fairly sure that it has wandered off into the weeds?

Agreed, the kernel currently uses a limit of 8.  And we should use a #define for this in lib/ext2fs/ext2fsP.h, and use it for both finddev.c and lib/ext2fs/namei.c.

-- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html