linux-ext4 - Re: [PATCH] mke2fs: do not initialize block bitmaps of groups having super block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D8CD6456-1740-4FA6-83E5-EFB0045EE74E@dilger.ca>
Date:	Wed, 9 Nov 2011 09:23:46 -0700
From:	Andreas Dilger <adilger@...ger.ca>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	"tytso@....edu" <tytso@....edu>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	Yongqiang Yang <xiaoqiangnk@...il.com>
Subject: Re: [PATCH] mke2fs: do not initialize block bitmaps of groups having super block

On 2011-11-09, at 3:53 AM, Yongqiang Yang <xiaoqiangnk@...il.com> wrote:

> Now mke2fs initializes block bitmaps of groups having super block, on
> the other hand ext4_init_block_bitmap in kernel can handle this case
> rightly.  So let mke2fs let block bitmaps of groups having super block
> be uninitialized.

Is that true of older kernels, or only newer ones?  What about filesystems with META_BG set?

Cheers, Andreas

> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
> ---
> lib/ext2fs/alloc_sb.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ext2fs/alloc_sb.c b/lib/ext2fs/alloc_sb.c
> index 0d1c000..7517fbc 100644
> --- a/lib/ext2fs/alloc_sb.c
> +++ b/lib/ext2fs/alloc_sb.c
> @@ -65,8 +65,6 @@ int ext2fs_reserve_super_and_bgd(ext2_filsys fs,
>        ext2fs_mark_block_bitmap2(bmap, 0);
> 
>    if (old_desc_blk) {
> -        if (fs->super->s_reserved_gdt_blocks && fs->block_map == bmap)
> -            ext2fs_bg_flags_clear(fs, group, EXT2_BG_BLOCK_UNINIT);
>        for (j=0; j < old_desc_blocks; j++)
>            if (old_desc_blk + j < ext2fs_blocks_count(fs->super))
>                ext2fs_mark_block_bitmap2(bmap,
> -- 
> 1.7.5.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html