linux-ext4 - Re: [PATCH] mke2fs: do not initialize block bitmaps of groups having super block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGBYx2Yk=yw9vjZ-015ow3Jw-bchV=1WEXj6wPAKwNRF+PYTwQ@mail.gmail.com>
Date:	Thu, 10 Nov 2011 10:07:50 +0800
From:	Yongqiang Yang <xiaoqiangnk@...il.com>
To:	Theodore Tso <tytso@....edu>
Cc:	Andreas Dilger <adilger@...ger.ca>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] mke2fs: do not initialize block bitmaps of groups having
 super block

On Thu, Nov 10, 2011 at 4:34 AM, Theodore Tso <tytso@....edu> wrote:
>
> On Nov 9, 2011, at 11:23 AM, Andreas Dilger wrote:
>
>> On 2011-11-09, at 3:53 AM, Yongqiang Yang <xiaoqiangnk@...il.com> wrote:
>>
>>> Now mke2fs initializes block bitmaps of groups having super block, on
>>> the other hand ext4_init_block_bitmap in kernel can handle this case
>>> rightly.  So let mke2fs let block bitmaps of groups having super block
>>> be uninitialized.
>>
>> Is that true of older kernels, or only newer ones?  What about filesystems with META_BG set?
>
> More to the point, what about file systems that don't have uninit_bg set?
mke2fs does not set BLOCK_UNINIT flag for file systems which do not
have uninit_bg set from the beginning.


>
> What's the reason for wanting to make this change?
The different handling to some groups let readers think that we have
to handle these groups this way, otherwise errors will happen.
Actually, no error will happen.   IMHO this can make both logic and
code much clearer.

Yongqiang.
>
> -- Ted
>
>
>



-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html