linux-ext4 - Re: e2fsprogs: Avoid infinite loop in ext2fs_find_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.01.1111200011530.8000@trent.utfs.org>
Date:	Sun, 20 Nov 2011 00:17:07 -0800 (PST)
From:	Christian Kujau <lists@...dbynature.de>
To:	Niu <niu@...mcloud.com>
cc:	Theodore Tso <tytso@....EDU>, Eric Sandeen <sandeen@...hat.com>,
	linux-ext4@...r.kernel.org
Subject: Re: e2fsprogs: Avoid infinite loop in ext2fs_find_block_device()

On Fri, 4 Nov 2011 at 20:50, Niu wrote:
> diff --git a/lib/ext2fs/ext2fsP.h b/lib/ext2fs/ext2fsP.h
> index b182d7f..82e1ba0 100644
> --- a/lib/ext2fs/ext2fsP.h
> +++ b/lib/ext2fs/ext2fsP.h
> @@ -11,6 +11,8 @@
>  
>  #include "ext2fs.h"
>  
[...]
> --- a/lib/ext2fs/finddev.c
> +++ b/lib/ext2fs/finddev.c
> @@ -34,6 +34,7 @@
>  
>  #include "ext2_fs.h"
>  #include "ext2fs.h"
> +#include "ext2fsP.h"

On the very real chance of making a fool of myself: if ext2fsP.h includes 
ext2fs.h and now finddev.c will include ext2fsP.h - shouldn't we omit the '#include 
"ext2fs.h"' in finddev.c (and namei.c) now?

I guess the compiler/preprocessor will figure this out, just wondering about
code cleanliness. Then again we have names like 'ext2_fs.h' and 
'ext2fs.h', I guess only an insider will know the difference :-)

Christian.
-- 
BOFH excuse #97:

Small animal kamikaze attack on power supplies
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html