linux-ext4 - Re: [PATCH] e2fsck: fix "can't find dup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111128170225.GA4348@thunk.org>
Date:	Mon, 28 Nov 2011 12:02:25 -0500
From:	Ted Ts'o <tytso@....edu>
To:	Robin Dong <hao.bigrat@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsck: fix "can't find dup_blk" error

Ok, I was able to replicate it, and created a small test case (see
attached), but it turns out your patch wasn't sufficient.  It didn't
actually fix the problem correctly, and left the file system in a
corrupted state, which was seen when we ran e2fsck a second time and
the i_blocks field was not correctly.

Your patch also resulted in blocks within a logical cluster
incorrectly assigned to two physical clusters.  (I still need to add
some code in e2fsck to notice this particular corruption, but it's
highly unlikely for this to happen due to hardware errors --- just
kernel/e2fsck bugs.)

I'll attach to this mail thread the patches I used to fix this, plus
the test case.

     	       	    	 	    	      - Ted

Download attachment "image.gz" of type "application/octet-stream" (4668 bytes)