linux-ext4 - Re: [PATCH] xfstests: Sort recursive getfattr output in 062

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111128110302.GD13766@infradead.org>
Date:	Mon, 28 Nov 2011 06:03:02 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Theodore Tso <tytso@....EDU>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	Yu Jian <yujian@...mcloud.com>,
	Andreas Dilger <adilger@...mcloud.com>,
	xfs-oss <xfs@....sgi.com>
Subject: Re: [PATCH] xfstests: Sort recursive getfattr output in 062

On Wed, Nov 23, 2011 at 11:09:37AM -0600, Eric Sandeen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Test 062 was made "generic" a while back, but it fails on any filesystem
> which returns getfattr -R results (aka readdir results) in something
> other than inode-order.
> 
> With a little awk-fu we can sort the records from getfattr -R so that
> the output is the same for xfs as well as ext4, etc.
> 
> Also filter out lost+found which extN creates at mkfs time, but
> some other filesystems do not.

Looks fine to me, except that I'd put the sorting helper into
common.attr.


Reviewed-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html