[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4EDF3C7F.4090801@tao.ma>
Date: Wed, 07 Dec 2011 18:14:23 +0800
From: Tao Ma <tm@....ma>
To: Andreas Dilger <adilger@...mcloud.com>
CC: djwong@...ibm.com, Theodore Ts'o <tytso@....edu>,
ext4 development <linux-ext4@...r.kernel.org>,
Liang Zhen <liang@...mcloud.com>
Subject: Re: [PATCH 01/02] ext2: reserve INCOMPAT_INLINEDATA feature flag
On 12/07/2011 05:45 PM, Andreas Dilger wrote:
> On 2011-12-06, at 5:39 PM, Darrick J. Wong wrote:
>> On Tue, Dec 06, 2011 at 05:13:51PM -0700, Andreas Dilger wrote:
>>> +#define EXT4_FEATURE_INCOMPAT_INLINEDATA 0x2000 /* data in inode */
>>
>> I was using 0x2000 for EXT4_FEATURE_INCOMPAT_BG_USE_META_CSUM, to change
>> the block group checksum to use crc32c.
>
> I didn't see that... I was looking at your patch and only noticed
> EXT4_FEATURE_RO_COMPAT_METADATA_CSUM. I suspect your patch is closer
> to landing it is better to use the 0x2000 value for BG_USE_META_CSUM,
> and change the value for INLINEDATA to 0x8000 instead.
OK, I will use this number for inline data for the new version if there
is no objection.
Thanks
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists