linux-ext4 - Re: [PATCH 14/51] dumpe2fs: Display block bitmap checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20111219195014.GI8233@tux1.beaverton.ibm.com>
Date:	Mon, 19 Dec 2011 11:50:14 -0800
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Andreas Dilger <adilger.kernel@...ger.ca>
Cc:	Theodore Tso <tytso@....edu>,
	Sunil Mushran <sunil.mushran@...cle.com>,
	Amir Goldstein <amir73il@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Mingming Cao <cmm@...ibm.com>,
	Joel Becker <jlbec@...lplan.org>, linux-ext4@...r.kernel.org,
	Coly Li <colyli@...il.com>
Subject: Re: [PATCH 14/51] dumpe2fs: Display block bitmap checksum

On Mon, Dec 19, 2011 at 11:50:06AM +0100, Andreas Dilger wrote:
> On 2011-12-14, at 2:14 AM, Darrick J. Wong wrote:
> > Display the block bitmap checksum when displaying block groups.
> > 
> > diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> > index 98bee2b..33c0933 100644
> > --- a/misc/dumpe2fs.c
> > +++ b/misc/dumpe2fs.c
> > @@ -222,6 +222,11 @@ static void list_desc (ext2_filsys fs)
> > 		print_number(ext2fs_block_bitmap_loc(fs, i));
> > 		print_bg_rel_offset(fs, ext2fs_block_bitmap_loc(fs, i), 0,
> > 				    first_block, last_block);
> > +		if (fs->super->s_desc_size >= EXT2_MIN_DESC_SIZE_64BIT &&
> > +		    fs->super->s_feature_ro_compat &
> > +		    EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)
> > +			printf(_(", csum 0x%08x"),
> > +			       ext2fs_block_bitmap_checksum(fs, i));
> 
> Printing the checksum should only depend on METADATA_CSUM, and has nothing
> to do with DESC_SIZE_64BIT.  That is a holdover from when there was only
> a 32-bit checksum for the inode/block bitmaps and no 16-bit checksum in
> the small group descriptor.

Oops, I will fix both of these.  Thank you for catching them!

--D
> 
> Cheers, Andreas
> 
> 
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html