linux-ext4 - Re: [PATCH 20/51] e2fsck: Verify extent tree blocks and clear the bad ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <FC050168-CB90-4951-9FE7-9D02596E0E23@whamcloud.com>
Date:	Mon, 19 Dec 2011 07:50:07 +0100
From:	Andreas Dilger <adilger@...mcloud.com>
To:	"Darrick J. Wong" <djwong@...ibm.com>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	Theodore Tso <tytso@....edu>,
	"Darrick J. Wong" <djwong@...ibm.com>,
	Sunil Mushran <sunil.mushran@...cle.com>,
	Amir Goldstein <amir73il@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Mingming Cao <cmm@...ibm.com>,
	Joel Becker <jlbec@...lplan.org>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	Coly Li <colyli@...il.com>
Subject: Re: [PATCH 20/51] e2fsck: Verify extent tree blocks and clear the bad ones

On 2011-12-14, at 2:15, "Darrick J. Wong" <djwong@...ibm.com> wrote:

> When we encounter an extent tree block that passes the header check but fails
> the checksum, offer to clear just that extent block instead of failing the
> whole tree, which results in the entire inode being wiped out.
> 
> diff --git a/e2fsck/problem.c b/e2fsck/problem.c
> index e74ad79..96b0de5 100644
> --- a/e2fsck/problem.c
> +++ b/e2fsck/problem.c
> @@ -946,6 +946,12 @@ static struct e2fsck_problem problem_table[] = {
>      N_("The bad @b @i looks @n.  "),
>      PROMPT_CLEAR, 0 },
> 
> +    /* Extent block does not match extent */
> +    { PR_1_EXTENT_CSUM_INVALID,
> +      N_("@i %i extent block checksum does not match extent\n\t(logical @b "
> +         "%c, @n physical @b %b, len %N)\n"),
> +      PROMPT_CLEAR, 0 },

Since the comment above the problem definition is the only place that the full string can be found, it should match the printed string exactly. In this case it is missing "inode" at the start and "checksum" in the middle of the comment. 

Cheers, Andreas--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html