linux-ext4 - Re: [PATCH 4/5] ext4: flush journal when switching from journal data mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111229210153.GN8233@tux1.beaverton.ibm.com>
Date:	Thu, 29 Dec 2011 13:01:53 -0800
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	"Ted Ts'o" <tytso@....edu>
Cc:	Yongqiang Yang <xiaoqiangnk@...il.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 4/5] ext4: flush journal when switching from journal
	data mode

On Wed, Dec 28, 2011 at 01:56:43PM -0500, Ted Ts'o wrote:
> On Tue, Nov 15, 2011 at 04:07:53PM +0800, Yongqiang Yang wrote:
> > When switching from journal data mode, the data blocks
> > in journal will have no revoke record.  Thus, data could be
> > corrupted during replay.  However, there is no such problem in
> > switching to journal data mode.  So we flush journal only in
> > the case that swithes from journal data mode.
> > 
> > Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
> 
> Applied, with a slightly different (and more explanatory commit
> message):
> 
> ext4: flush journal when switching from data=journal mode
> 
> From: Yongqiang Yang <xiaoqiangnk@...il.com>
> 
> It's necessary to flush the journal when switching away from
> data=journal mode.  This is because there are no revoke records when
> we are data blocks are journalled,

Minor nit, but did you mean "when data blocks are journalled" ?

--D
> which are required in the other journal modes.
> 
> However, it is not necessary to flush the journal when switching into
> data=journal mode, and flushing the journal is expensive.  So let's
> avoid it in that case.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> 
> 						- Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html