linux-ext4 - Re: [PATCH 2/5] ext4: let ext4 journal deletion of data blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111230150557.GC29547@thunk.org>
Date:	Fri, 30 Dec 2011 10:05:57 -0500
From:	Ted Ts'o <tytso@....edu>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/5] ext4: let ext4 journal deletion of data blocks

On Fri, Dec 30, 2011 at 10:59:48PM +0800, Yongqiang Yang wrote:
> Hi Ted,
> 
> The 2nd and 3rd patch aim to let ext4_free_blocks work with journal
> mode.  Consider that journal mode of a file is changed from ordered
> mode to journal mode and several data blocks are deleted, then bh
> passed in is NULL and sb_find_get_block returns NULL, but we need
> ext4_forget to handle the data blocks to record them in revoke table.

Ah, I see.  This wasn't obvious from the commit description.  Could
you combine patches #2 and #3, and add the above detail in the commit
description?

Many thanks!!

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html