lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120103104749.GA18875@dztty> Date: Tue, 3 Jan 2012 11:47:49 +0100 From: Djalal Harouni <tixxdz@...ndz.org> To: Yongqiang Yang <xiaoqiangnk@...il.com> Cc: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH] fs/ext4: add missing ext4_resize_end On Fri, Dec 23, 2011 at 09:14:20AM +0800, Yongqiang Yang wrote: > Thanks. > > The patch looks good. I have to update the new resize patch too. > > Yongqiang. > > On Thu, Dec 22, 2011 at 11:00 PM, Djalal Harouni <tixxdz@...ndz.org> wrote: > > Online resize ioctls 'EXT4_IOC_GROUP_EXTEND' and 'EXT4_IOC_GROUP_ADD' > > call ext4_resize_begin() to check permissions and to set the > > EXT4_RESIZING bit lock, they do their work and they must finish with > > ext4_resize_end() which calls clear_bit_unlock() to unlock and to > > avoid -EBUSY errors for the next resize operations. > > > > This patch adds the missing ext4_resize_end() calls on error paths. Any news on this one ? If we call EXT4_IOC_GROUP_EXTEND ioctl and get_user() fails with -EFAULT then any new call will return -EBUSY, unless we unmount/mount the fs. In rare situations this can lead to a corrupt filesystem, I've experienced this, but I'm not sure what I did. fsck fix it. Thanks. -- tixxdz http://opendz.org -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists