lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 3 Jan 2012 21:44:52 -0500
From:	Ted Ts'o <tytso@....edu>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH V6 RESEND 07/15] ext4: add a function which adds
 several group descriptors

On Fri, Dec 30, 2011 at 07:00:04PM +0800, Yongqiang Yang wrote:
> From: Yongqiang Yang <xiaoqiangnk@...il.com>
> 
> This patch adds a functon named ext4_add_new_descs() which adds
> several group descriptors each time.

This is why it's less desirable to add functions one at a time.  I had
to look through all of the patches to determine that
ext4_add_new_desc() is _only_ being called by ext4_add_new_descs().
And since ext4_add_new_descs() adds so little new value, it's better
to combine these two functions together into single function.

I'll add a new patch which folds these two functions together.

   	   	     	       		     	    - Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists