linux-ext4 - Re: [PATCH v5] ext4: make quota as first class supported feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120112105555.GA5374@granier.hd.free.fr>
Date:	Thu, 12 Jan 2012 11:55:55 +0100
From:	Johann Lombardi <johann@...mcloud.com>
To:	Aditya Kali <adityakali@...gle.com>
Cc:	adilger@...ger.ca, tytso@....edu, dmonakhov@...nvz.org,
	jack@...e.cz, linux-ext4@...r.kernel.org
Subject: Re: [PATCH v5] ext4: make quota as first class supported feature

On Wed, Jan 11, 2012 at 11:11:56AM -0800, Aditya Kali wrote:
> This patch is an attempt towards supporting quotas as first class
> feature in ext4. It is based on the proposal at:
> https://ext4.wiki.kernel.org/index.php/Design_For_1st_Class_Quota_in_Ext4
> This patch introduces a new feature - EXT4_FEATURE_RO_COMPAT_QUOTA which, when
> turned on, enables quota accounting at mount time iteself. Also, the
> quota inodes are stored in two additional superblock fields.
> Some changes introduced by this patch that should be pointed out are:
> 1) Two new ext4-superblock fields - s_usr_quota_inum and s_grp_quota_inum
>    for storing the quota inodes in use.
> 2) Default quota inodes are: inode#3 for tracking userquota and inode#4 for
>    tracking group quota. The superblock fields can be set to use other inodes
>    as well.
> 3) If the QUOTA feature and corresponding quota inodes are set in superblock,
>    the quota usage tracking is turned on at mount time. On 'quotaon' ioctl, the
>    quota limits enforcement is turned on. 'quotaoff' ioctl turns off only the
>    limits enforcement in this case.
> 4) When QUOTA feature is in use, the quota mount options 'quota', 'usrquota',
>    'grpquota' are ignored by the kernel.
> 5) mke2fs or tune2fs can be used to set the QUOTA feature and initialize quota
>    inodes. The default reserved inodes will not be visible to user as
>    regular files.
> 6) The quota-tools will need to be modified to support hidden quota files on
>    ext4. E2fsprogs will also include support for creating and fixing quota
>    files.
> 7) Support is only for the new V2 quota file format.
> 
> Signed-off-by: Aditya Kali <adityakali@...gle.com>

Looks good to me.
Reviewed-by: Johann Lombardi <johann@...mcloud.com>

Johann
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html