lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 19 Jan 2012 12:37:48 -0600
From:	Eric Sandeen <sandeen@...deen.net>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Eric Sandeen <sandeen@...hat.com>,
	ext4 development <linux-ext4@...r.kernel.org>,
	xfs-oss <xfs@....sgi.com>
Subject: Re: [PATCH] xfstests: mount other filesystems with selinux context
 as well

On 11/28/11 5:02 AM, Christoph Hellwig wrote:
> On Wed, Nov 23, 2011 at 11:50:26AM -0600, Eric Sandeen wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> For some reason, non-xfs filesystems aren't getting mounted with
>> the selinux context; perhaps because none of the xattr tests used
>> to work on anything but xfs?
>>
>> Anyway, 062 fails for extN unless we mount with the fs-wide
>> context.
>>
>> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
>> - ---
>>
>> diff --git a/common.rc b/common.rc
>> index cab0b64..5998ff2 100644
>> - --- a/common.rc
>> +++ b/common.rc
>> @@ -86,14 +86,17 @@ _mount_opts()
>>  	export MOUNT_OPTIONS=$NFS_MOUNT_OPTIONS
>>  	;;
>>      ext2|ext3|ext4|ext4dev)
>> - -	# acls & xattrs aren't turned on by default on ext$FOO
>> +	export SELINUX_MOUNT_OPTIONS
>> +	# acls & xattrs aren't turned on by default on ext$FOO in old kernels
>>  	export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
>>  	;;
>>      reiserfs)
>> +	export SELINUX_MOUNT_OPTIONS
>>  	# acls & xattrs aren't turned on by default on reiserfs
>>  	export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
>>  	;;
>>      gfs2)
>> +	export SELINUX_MOUNT_OPTIONS
>>  	# acls aren't turned on by default on gfs2
>>  	export MOUNT_OPTIONS="-o acl $GFS2_MOUNT_OPTIONS"
>>  	;;
> 
> shouldn't the "export SELINUX_MOUNT_OPTIONS" simply move to common code?

I wasn't sure if nfs would grok it.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists